Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shader image query instructions #608

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Add shader image query instructions #608

merged 3 commits into from
Apr 30, 2021

Conversation

khyperia
Copy link
Contributor

Ticks some more boxes off in #204

@khyperia khyperia requested a review from eddyb as a code owner April 29, 2021 11:56
XAMPPRocky
XAMPPRocky approved these changes Apr 29, 2021
View reviewed changes
crates/rustc_codegen_spirv/src/builder/spirv_asm.rs Show resolved Hide resolved
crates/rustc_codegen_spirv/src/builder/spirv_asm.rs Show resolved Hide resolved
crates/rustc_codegen_spirv/src/builder/spirv_asm.rs Show resolved Hide resolved
crates/spirv-std/src/image.rs
/// 3D, or Cube, it must have *either* multisampled be true, *or* sampled of Unknown or No.
#[crate::macros::gpu_only]
#[doc(alias = "OpImageQuerySize")]
pub fn query_size<Size: ImageCoordinate<u32, DIM, ARRAYED> + Default>(&self) -> Size {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ImageCoordinate itself could probably require all implementations to also have Default as the only valid image coordinate types are vectors and scalars all of which impl Default.

tests/ui/image/query/query_levels_err.stderr Outdated Show resolved Hide resolved
tests/ui/image/query/query_lod_err.stderr Outdated Show resolved Hide resolved
@khyperia khyperia merged commit 7a6806c into main Apr 30, 2021
@khyperia khyperia deleted the add-image-queries branch April 30, 2021 07:07
XAMPPRocky pushed a commit that referenced this pull request May 3, 2021
@khyperia @XAMPPRocky
Add shader image query instructions (#608)
2ca5612 
* Add shader image query instructions

* Normalize spirv-std src paths in test output

* Fix tests on vulkan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XAMPPRocky XAMPPRocky XAMPPRocky approved these changes

@eddyb eddyb eddyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khyperia @eddyb @XAMPPRocky